jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.26k stars 508 forks source link

Update @rollup/plugin-commonjs to the latest version πŸš€ #727

Closed greenkeeper[bot] closed 3 years ago

greenkeeper[bot] commented 4 years ago

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! πŸ’œ πŸššπŸ’¨ πŸ’š

Find out how to migrate to Snyk at greenkeeper.io


The dependency @rollup/plugin-commonjs was updated from 11.1.0 to 12.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: shellscape License: MIT

Find out more about this release.


FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper bot :palm_tree:

agilgur5 commented 4 years ago

Changelog here. It's actually up to v15 now. Doesn't seem ike most of the changes should affect us, mostly removing some imports we don't use and CJS/ESM export stuff similar to #726

agilgur5 commented 4 years ago

Welp, tried upgrading and got a warning on install πŸ˜• :

warning " > @rollup/plugin-commonjs@15.0.0" has incorrect peer dependency "rollup@^2.22.0".

This peerDep was actually changed during v12.0.0, but of course the Changelog makes no mention of it... https://github.com/rollup/plugins/pull/149, the PR that adds it, does say it includes a breaking change with that change πŸ˜• πŸ˜•

So this is blocked on Rollup 2 upgrade #545

agilgur5 commented 3 years ago

Superseded by #889