search

jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.26k stars 508 forks source link

deps: upgrade actions/cache to v2 in all templates #750

Closed devrelm closed 4 years ago

devrelm commented 4 years ago

actions/cache@2 has been released and comes with some useful updates.

agilgur5 commented 4 years ago

Thanks, will merge this in this weekend or next week when I'm back from vacation.

The current implementation is flawed btw, as it caches node_modules instead of yarn-cache or ~/.npm. I've been planning on changing the templates to use the npm_install action as TSDX uses as of #625, but that one is buggy on Mac and Windows and my issue report hasn't been responded to https://github.com/bahmutov/npm-install/issues/24. Planning to fork and fix that, but it relies on a fork of some of the GH actions since there weren't NPM packages of them -- now there are per the changelog so that should make that easier.

This is still an improvement over the current version so still makes sense to merge until that is ready.

agilgur5 commented 4 years ago

@allcontributors please add @devrelm for code

allcontributors[bot] commented 4 years ago

@agilgur5

I've put up a pull request to add @devrelm! :tada: