search

jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.28k stars 507 forks source link

Upgrade from rollup-plugin-babel to @rollup/plugin-babel #789

Closed vladdy-moses closed 4 years ago

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/ff7ar8nbs
✅ Preview: https://tsdx-git-fork-vladdy-moses-update-rollup-babel-plugin.formium.vercel.app

vladdy-moses commented 4 years ago

Also fixed _Node CI / Lint on node 10.x and ubuntu-latest (pullrequest) check.

jaredpalmer commented 4 years ago

I thnk this closes #792

agilgur5 commented 4 years ago

@jaredpalmer I'm not sure how those two are related (nor did you specify)... I just closed that one, it's a transient core-js postinstall error that shouldn't affect anything and is very upstream. This PR doesn't change anything related to core-js. It happens to remove one of the deprecation notices logged in that issue but does not fix the central error that issue is reporting...

agilgur5 commented 4 years ago

Have taken over this myself since this has been stale for several weeks and is one of the last dep updates being added to v0.14.0, which is just about ready otherwise. This also fits into the theme as an upgrade that requires Node 10+.

I've removed the change I requested to be removed, rebased the PR and fixed the yarn.lock and package.json conflicts, and tests are looking to pass now.

I assume this is just to get rid of a deprecation notice, however it would be better not to assume.

Yup, seems to be so, got this warning on a fresh install of v0.13.3:

npm WARN deprecated rollup-plugin-babel@4.4.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-babel.
agilgur5 commented 4 years ago

Removed the two leftover references to rollup-plugin-babel, one was an old commented out import, another was a declare module, which is no longer necessary because @rollup/plugin-babel ships its own typings.

agilgur5 commented 4 years ago

@allcontributors please add @vladdy-moses for code

allcontributors[bot] commented 4 years ago

@agilgur5

I've put up a pull request to add @vladdy-moses! :tada: