Fix formatting and lint errors from previous PRs

agilgur5 commented 4 years ago

Description

Commits

format: auto-fix help dialog formatting error

with yarn lint --fix
formatting error is from 8b148ce

format: auto-fix new website formatting errors

with yarn lint --fix
formatting errors are from b09e195

lint: manually fix new website ESLint errors and warnings

these were unable to be auto-fixed, so I had to manually fix them
lint errors are from b09e195

Review Notes

Not sure why nextra has some of these lint errors built into their examples (lack of React, noreferrer, etc), though the project does explicitly say that it is not production ready. Perhaps worth an upstream PR or two.

I plan to merge this myself, but in case someone else decides to beforehand, please ensure to rebase (not squash merge) the changes in as they're intentionally 3 separate commits.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/rdlvaycnh ✅ Preview: https://tsdx-git-fork-agilgur5-fix-website-etc-formatting-error.formium.vercel.app

agilgur5 commented 4 years ago

CI is failing on install for certain jobs (race condition) because I accidentally broke upstream @bahmutov/npm-install when my PR https://github.com/bahmutov/npm-install/pull/37 got merged per https://github.com/bahmutov/npm-install/issues/39#issuecomment-673858078

agilgur5 commented 4 years ago

Re-ran CI after my hotfix upstream got merged: https://github.com/bahmutov/npm-install/pull/40 . install on all passed now, but were also all cache hits this time around 🤔

jaredpalmer / tsdx