search

jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.26k stars 508 forks source link

[Snyk] Upgrade next from 9.4.4 to 9.5.0 #807

Closed snyk-bot closed 4 years ago

snyk-bot commented 4 years ago

Snyk has created this PR to upgrade next from 9.4.4 to 9.5.0.

merge advice

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/4qudvcpgo
✅ Preview: https://tsdx-git-snyk-upgrade-b86d1f4c0c38ef74a52a9e19fed8886c.formium.vercel.app

agilgur5 commented 4 years ago

@jaredpalmer can you please give me admin access to Snyk and any other bots (including Vercel, ImgBot, and dependabot)? This is Snyk's second duplicate of #806 and #804 and all three of them unnecessarily bump a minor version when the package.json SemVer policy allows minors anyway. And all of them are to the website, so it doesn't matter if those deps are up to date (or vulnerable) anyway. Snyk also isn't labeling its PRs which makes it difficult to sort through.

As I've mentioned to you before, Greenkeeper was similar and was just making dozens of unnecessary PRs that clog notifications, clog search, clog PR view, and give a bad image but I had no way of changing it (or upgrading to Snyk) since I had no access. Now Snyk is even worse and I sill have no access after asking for months and you're not responding to its PRs either (so I have no control over something I didn't add but have to maintain it somehow). If we keep letting Snyk do its thing for unnecessary patches, minors, etc the repo is going to be 90% dep PRs (it's probably at least 5% already, if not 10%) and 90% dep commits if those were merged. It's adding a ton of unnecessary noise with very little signal right now, with bugs at that

agilgur5 commented 4 years ago

And now it opened yet another PR for a patch bump in #809... Greenkeeper would at least re-use PRs, Snyk is going crazy cluttering all the PRs, I can't see how this is would be considered useful...

@jaredpalmer please give me admin access to Snyk and all other bots, this is really frustrating to deal with and I have no control over it

agilgur5 commented 4 years ago

@jaredpalmer It just made another duplicate with #812... it's literally making two unnecessary PRs a day and I have no control over it

agilgur5 commented 4 years ago

@jaredpalmer And it just made one more duplicate with #813 ... this is just ridiculous now...

agilgur5 commented 4 years ago

@jaredpalmer one more duplicate with #825 ... It also just made 5 more unnecessary PRs to upgrade minor versions of dependencies that are only pinned to majors anyway... See the "unnecessary" label I've added to track these and PRs to website/

agilgur5 commented 4 years ago

Snyk has been removed (response was on the wrong issue again... asked about that here). Closing, per above, as since this just updated a minor, which wasn't pinned anyway, and was on the /website dir, which isn't a library.