search

jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.26k stars 508 forks source link

Rollup 2 support #821

Closed cncolder closed 4 years ago

cncolder commented 4 years ago

Current Behavior

tsdx lock rollup@1.32.1 now

Desired Behavior

Upgrade to rollup 2

Suggested Solution

Release npm next tag tsdx@next

Who does this impact? Who is this for?

Some plugins (e.g. rollup-plugin-postcss) has drop support rollup 1

Describe alternatives you've considered

Additional context

agilgur5 commented 4 years ago

Yea planning on doing this soon since https://github.com/formium/tsdx/pull/731#issuecomment-672246494 is causing a high vulnerability and requires Rollup v2.

Per https://github.com/formium/tsdx/pull/679#issuecomment-631478298, it wasn't easily possible before and rollup-plugin-postcss itself broke during the upgrade. Now enough time should have elapsed that it should be doable to upgrade it and all the related deps, but it's potentially quite breaking for tsdx.config.js users in potentially unexpected ways. TS 3.8 private fields still have issues in a lot of places, but based on reports looks like we can update to TS 3.8+ safely so long as private fields aren't used.

agilgur5 commented 4 years ago

Duplicate of #545