jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.27k stars 507 forks source link

Refactor build-default tests for more explicitness and correctness checks #903

Closed agilgur5 closed 4 years ago

agilgur5 commented 4 years ago

Description

Summary by Commit Message

refactor: move unbundled regenerator test to build-options

refactor: use a less noisy side-effect for async regression test

refactor: be more descriptive than "blah", "foo", "bar" in tests

fix/docs: basic README should reference .ts, not .tsx files

This one is unrelated to the rest, just found it as I was refactoring for the previous commit

refactor/test: test for correctness of syntax, not just parsing

Tags

Review Notes

Been wanting to do the explicitness for a while. Consistency in the syntax testing I thought would help (for my own use writing tests too) and correctness seemed to make more sense and was something I already did with the generator test (so this makes the others consistent in checking for correctness as well). I didn't actually add correctness tests (i.e. checking the value) until now, maybe because I forgot I already had a place in the test suite to do so.

This doesn't change any actual source code or meaningful template code.

Will rebase these in.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

šŸ” Inspect: https://vercel.com/formium/tsdx/q4e3nghw9
āœ… Preview: https://tsdx-git-refactor-test-build-default.formium.vercel.app

agilgur5 commented 4 years ago

Test passes now, not sure why it failed that one time. First time I've seen that error and it's in a section of the test suite that I didn't change and a not so important test, so going to merge.