Closed agilgur5 closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
š Inspect: https://vercel.com/formium/tsdx/q4e3nghw9
ā
Preview: https://tsdx-git-refactor-test-build-default.formium.vercel.app
Test passes now, not sure why it failed that one time. First time I've seen that error and it's in a section of the test suite that I didn't change and a not so important test, so going to merge.
Description
Summary by Commit Message
refactor: move unbundled regenerator test to build-options
--target node
, so it should be in build-options as that's not a zero-config defaultrefactor: use a less noisy side-effect for async regression test
require
s) the actual built library in order to ensure correctnessrefactor: be more descriptive than "blah", "foo", "bar" in tests
fix/docs: basic README should reference .ts, not .tsx files
it uses normal .ts files and no JSX (that's what the React template is for after all), so README shouldn't mention .tsx
woops, this was probably a copy+paste error on my behalf when I was improving the basic template's docs
This one is unrelated to the rest, just found it as I was refactoring for the previous commit
refactor/test: test for correctness of syntax, not just parsing
Tags
build-options
was only just added with my smoke test in #896, so I must've forgot to split out files before.41 and #46 previously removed some swear words, but not all
Review Notes
Been wanting to do the explicitness for a while. Consistency in the syntax testing I thought would help (for my own use writing tests too) and correctness seemed to make more sense and was something I already did with the generator test (so this makes the others consistent in checking for correctness as well). I didn't actually add correctness tests (i.e. checking the value) until now, maybe because I forgot I already had a place in the test suite to do so.
This doesn't change any actual source code or meaningful template code.
Will rebase these in.