Closed agilgur5 closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/formium/tsdx/ckr72tuhx
✅ Preview: https://tsdx-git-deps-dont-update-peers.formium.vercel.app
Seems like https://github.com/microsoft/tslib/issues/22 exists that goes into this. https://github.com/microsoft/tslib/issues/22#issuecomment-318492123 seemed against using peerDeps but without an example that was difficult to understand how the use-case actually plays out (does it mean in the dependency tree or a single package?)
Since older versions of tslib
seem to be forward-compatible, it seems like the decision to upgrade tslib
would be independent of TS upgrade as a result, so might not make sense to ignore it then.
Added a comment in the thread upstream, but think this is good to go as is due to above. Can always add more to the list as well.
Cleaned up ~74 Greenkeeper branches associated with @typescript-eslint/eslint-plugin
, @typescript-eslint/parser
, eslint-plugin-flowtype
, eslint-plugin-import
, eslint-plugin-react
, eslint-plugin-react-hooks
, @types/jest
, and jest-watch-typeahead
.
Think nearly all the rest can be cleaned up now too (~44 left). I think they're mostly minor version upgrades (hence no PR) or devDeps or both. Has taken a while to get here, have cleaned up 100s of Greenkeeper branches 😕
Deleted another ~12 Greenkeeper branches. They were mostly patch bumps of devDeps actually, a few minors and a few prod. Remaining ones seem to be all Prettier/eslint-config-prettier
/eslint-plugin-prettier
deps or template version bumps in the example
dir
Description
several of the dependencies in the tree are only there because they are peerDeps, and not because we directly depend on them
Greenkeeper made several PRs for peers which previously caused an erroneous/buggy update of
@types/jest
to 25 many months before Jest was upgraded to 25Tags
462 was a previous erroneous PR due to Greenkeeper updating peers, which was reverted in #470
eslint-config-react-app
peers in https://github.com/formium/tsdx/pull/640#issuecomment-702894150 / https://github.com/formium/tsdx/pull/642#issuecomment-702892887 / https://github.com/formium/tsdx/pull/728#issuecomment-702892139 / https://github.com/formium/tsdx/pull/729#issuecomment-702892420 / https://github.com/formium/tsdx/pull/890#issuecomment-700292943709 updated
jest-watch-typeahead
to a version for Jest 26 before we even upgraded to Jest 25Let's close some of the confusing Greenkeeper peer update PRs now that this has been configured:
Review Notes
I straight copy+pasted the
eslint-config-react-app
peerDeps from itspackage.json
, so they're alphabetized the same way and shouldn't have any spelling mistakes.