search

jaredpalmer / tsdx

Zero-config CLI for TypeScript package development
https://tsdx.io
MIT License
11.27k stars 507 forks source link

fix: relative links in website to absolute links #923

Closed felixmosh closed 3 years ago

felixmosh commented 3 years ago

Maintainer edit:

Closes #844

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/formium/tsdx/qfmj3i24j
✅ Preview: https://tsdx-git-patch-1.formium.vercel.app

agilgur5 commented 3 years ago

Supersedes #844 with a valid solution to another issue with #765 , though my remarks in https://github.com/formium/tsdx/pull/844#issuecomment-683764069 still stand, especially as the website has no versioning. The website is also a bit outdated now because it was never synced with the README (c.f. https://github.com/formium/tsdx/pull/844#issuecomment-683448861, #848).

This is still a good change though, so will accept this as incremental improvement even though it does not solve all the problems.

agilgur5 commented 3 years ago

Another test timeout but only 1 this time. I'll merge since this is quite safe to change, doesn't affect any actual code, and was manually tested.

agilgur5 commented 3 years ago

@allcontributors please add @felixmosh for docs. Thanks for the contribution

allcontributors[bot] commented 3 years ago

@agilgur5

I've put up a pull request to add @felixmosh! :tada: