search

jaredpar / basic-reference-assemblies

Produce NuPkg files that have .NET Reference assemblies as resources
MIT License
96 stars 15 forks source link

WithReferenceAssemblies Extension Improvement #21

Open tanveerbadar opened 2 years ago

tanveerbadar commented 2 years ago

Hello!

First of, thank you for creating this awesome package. It solved some major headaches for me.

May I suggest an improvement to WithReferenceAssembleis extension method?

Currently, it is implemented as compilation.WithReferences(...) which replaces everything one might have provided during compilation creation. Would it be better to replace it with compilation.AddReferences() which does preserve the existing references?

If the idea sounds good, I can submit a PR to the effect.

jaredpar commented 2 years ago

I think there is value in both variations of the methods. Essentially one that replaces the entire set of references and one that adds the references. So rather than "replace" I'd be interested in a PR that augments the existing capability.

I think that AddReferences is a good name for the API you are suggesting.

tanveerbadar commented 2 years ago

That's much better! PR on the way in a day or two.

tanveerbadar commented 2 years ago

That's much better! PR on the way in a day or two.

RFC1920 commented 2 years ago

Has there been any movement on this? I am struggling with similar issues in that I need to be able to add additional references.