jaredpetersen / kafka-connect-arangodb

🥑 Kafka connect sink connector for ArangoDB
https://www.confluent.io/connector/kafka-connect-arangodb/
MIT License
30 stars 8 forks source link

Implement useSSL connection config option #11

Closed rsolano closed 4 years ago

rsolano commented 4 years ago

Adds the useSsl option available via the Java ArangoDB driver.

jaredpetersen commented 4 years ago

After you merge this, I'll try to get this fully deployed to Maven Central as soon as I can. The process is partially automated but Maven Central still requires button clicks in a UI unless you use a specialized maven plugin.

rsolano commented 4 years ago

Sounds good, thanks! Looks like you'll have to merge it for me though.

jaredpetersen commented 4 years ago

I was wondering if that was the case... Sorry!

Ah, shoot. One more change that I forgot about. Please update the CHANGELOG. Something simple like:

## [1.0.7] - 2020-03-10
### Changed
- Added support for SSL

The GitHub release is auto-generated so keeping track of changes in the CHANGELOG is the best way of communicating this sort of thing.

Thanks for your contribution and sorry for the inconvenience 😓

rsolano commented 4 years ago

Absolutely, no worries and thank you for making this connector!

jaredpetersen commented 4 years ago

@rsolano Your change has been deployed to maven central. Thanks again! 🚀