search

jaredwray / flat-cache

A stupidly simple key/value storage using files to persist the data
MIT License
165 stars 30 forks source link

circular-json in maintenance #22

Closed hozefaj closed 5 years ago

hozefaj commented 5 years ago

Getting the below warning when circular-json is installed as a dependency.

CircularJSON is in maintenance only, flatted is its successor.

Maybe worth while to update dependency to use flatted....https://github.com/WebReflection/flatted

ai commented 5 years ago

Fix https://github.com/royriojas/flat-cache/pull/23

royriojas commented 5 years ago

closed by #23

royriojas commented 5 years ago

Sadly this broke the eslint tests (not sure how) but it is most likely an issue with the way the cache is generated. We're missing a unit test there.

hudochenkov commented 5 years ago

It also broke stylelint tests: https://github.com/stylelint/stylelint/issues/3779#issuecomment-436687938 (more info about flat-cache update there). It's kind of our fault, we test implementation detail of dependency of a dependency of a dependency. In our case, it's output of circular-json, which is a dependency of flat-cache, which is a dependency of file-entry-cache.

@royriojas there is no your fault. file-cache works with flatted as expected. Both stylelint and eslint worked with flat-cache@1.3.1 good. It's just our tests doing bad things :)

royriojas commented 5 years ago

Hi @hudochenkov, you're right this is probably the same issue in the eslint repo. Didn't realize it before reverting. Sorry.

When I test the module it works when using the api, it is only that the tests in eslint were also testing using the output structure of circular-json. If that is the issue then we might be able to upgrade flat-cache but using a major version and make a PR on eslint upgrading the dep and fixing the tests.

Thank u!

cktang88 commented 5 years ago

closed by #35

AlexWayfer commented 5 years ago

closed by #35

By duplicated issue?

I think, it closed by #36.