search

jaredwray / flat-cache

A stupidly simple key/value storage using files to persist the data
MIT License
165 stars 30 forks source link

Change JSON parser from circular-json to flatted & 1 more changes #37

Closed shanoaice closed 5 years ago

shanoaice commented 5 years ago
mikaelmello commented 5 years ago

@royriojas could you please make this change?

It is causing a warning on every eslint install

royriojas commented 5 years ago

Hi @mikaelmello, I will merge this today, but we also need to release this at least as a minor release and then make a PR on eslint to fix the broken unit tests. That part is what blocked me, since I didn't have the time yet to do that.

In any case it might not be that complicated, an a PR that help with that on the eslint repo will be nice.

@KsRyY Thanks for your PR, there is already another one open for the same issue, I will go ahead and merge that one and also merge yours as yours fixes the travis tests. But I believe we should also use the same node versions that eslint use in its travis.yml