search

jaredwray / flat-cache

A stupidly simple key/value storage using files to persist the data
MIT License
165 stars 30 forks source link

[Snyk] Security upgrade write from 1.0.3 to 2.0.0 #45

Closed snyk-bot closed 3 years ago

snyk-bot commented 4 years ago

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
medium severity Prototype Pollution
SNYK-JS-MINIMIST-559764		 Yes Proof of Concept
Commit messages
Package name: write The new version differs by 17 commits.
  • f537eb6 2.0.0
  • 07a6c43 update docs
  • 9081d22 use `add-filename-increment`
  • 006fb4a Merge pull request #8 from jonschlinkert/2.0
  • 601522a use `.resolve` in tests
  • 0b288ec use `.resolve` instead of `.join`
  • 7feaaf6 add `prev` check to `incrementName()`
  • 7d79ef2 Merge remote-tracking branch 'origin/master' into 2.0
  • f378047 Fixes per @doowb's code review on https://github.com/jonschlinkert/write/pull/8
  • 4cd516f fix badge
  • 6d9338d fix badge
  • e996f21 node 10
  • f78f4ee refactor
  • 12fc942 Merge pull request #6 from jpetitcolas/add_end_new_line
  • 68b61f6 Introduce ensureNewLine option parameter
  • b0efe25 Add end file new line
  • f539751 1.0.3
See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:

🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

will-in-wi commented 4 years ago

My team just encountered this as well.

DullReferenceException commented 4 years ago

Seems like write@2 only supports node@>=10, unfortunately. The API calls look like they're correct still, though. Would a major bump of flat-cache that obsoletes older versions of node be a bad thing?

pskfry commented 4 years ago

just encountered this as well. any chance we could see this bump happen?

royriojas commented 4 years ago

There is a PR opened for this, but I was seriously considering inlining the write module as we only use the sync version. I also have to be very careful and align support with file-entry-cache to avoid breaking eslint. Will find sometime during this weekend

anmoldalmia commented 4 years ago

Recently affected by this as well, any news for this PR?