jaredwray / flat-cache

A stupidly simple key/value storage using files to persist the data
MIT License
165 stars 30 forks source link

Update minimist to 1.2.3 or later #47

Closed p1ho closed 1 year ago

p1ho commented 4 years ago

Hello, just found this out, so wanted to open an issue.

minimist released a security statement to use version 1.2.3 or later due to a prototype pollution bug

minimist is not a top level dependency (It's not in package.json), but it is present in package-lock.json (a word search reveals 21 occurrences)

This means projects with flat-cache as dependency and a build process that includes checking vulnerability (through $ npm audit) might have a fail build because of it. I was wondering if you can please take a look, thanks!

jfoclpf commented 4 years ago

Please update the write dependency asap to v 2.0.0. That's what is disseminating the vulnerability

SuperITMan commented 4 years ago

This should be solved by #46

royriojas commented 4 years ago

Is this a real issue? I mean, it is a devDependency for this project, how is it that minimist ended being installed? is it a dependency of flatted or rimraf?

SuperITMan commented 4 years ago

Hello @royriojas

Actually, the description of the issue is not 100% correct. As @jfoclpf mentioned, the dependency write of flat-cache has be updated to version > 2.0.0 asap. Because

flat-cache - 2.0.1:
  - write - 1.0.3: 
    - mkdirp - ^0.5.0:
      - minimist - 0.0.8

Thanks for your lib 😊

yumetodo commented 4 years ago

To update write to >=2.0.0, please drop support node.js < 10 and merge #46.

jaredwray commented 1 year ago

@yumetodo - we will be removing nodejs 10 support in the upcoming weeks.