jaredwray / flat-cache

A stupidly simple key/value storage using files to persist the data
MIT License
165 stars 30 forks source link

Switch from cjs to ESM? #60

Closed jimmywarting closed 1 year ago

jimmywarting commented 3 years ago

Many modules are switching to ESM to support both Deno and browser imports without bundeling. Think you should make the switch as well...

Can make a PR if u like

would require at least node v12.17

royriojas commented 3 years ago

Sure that would be nice!

Roy Ronald Riojas Montenegro

On Sat, Aug 14, 2021 at 12:39 PM Jimmy Wärting @.***> wrote:

Many modules are switching to ESM to support both Deno and browser imports without bundeling. Think you should make the switch as well...

Can make a PR if u like

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/royriojas/flat-cache/issues/60, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABABWWT55OK3O3ICHBVPWDT43BADANCNFSM5CFMIY2Q .

jimmywarting commented 3 years ago

If you merge #58 than i can have a crack at making a ESM pr and also remove rimraf (if possible) or do you want separate PR for that? (easier to review)

jimmywarting commented 3 years ago

Mather of facts, i think it would be best if you first switch to github actions before i make any PR's ?

jaredwray commented 1 year ago

@jimmywarting - we will be updating the actions and code coverage work in the next 2-6 weeks.

jaredwray commented 1 year ago

@jimmywarting - we will probably want to move this to some more modern code before. I will ping you after we get that updated first.