search

jaredwray / keyv

Simple key-value storage with support for multiple backends
https://keyv.org
MIT License
2.56k stars 139 forks source link

[@keyv/redis] Migrate to node-redis from ioredis #1119

Open jftanner opened 1 week ago

jftanner commented 1 week ago

Is your feature request related to a problem? Please describe. This was mentioned as part of https://github.com/jaredwray/keyv/issues/868, but not implemented as part of it. So this isn't new, but doesn't currently have an issue to track it.

With the effective deprecation of ioredis, devs are encouraged to switch to the official node-redis module instead. But, currently, that's not compatible with Keyv without a shim.

Describe the solution you'd like One of two options:

  1. A new @keyv/node-redis module
  2. Migrate @keyv/redis to use node-redis instead.

In the latter case, it would either be a breaking change or would require a shim to still accept an ioredis instance passed to the constructor (new KeyvRedis(redis);).

jaredwray commented 1 week ago

@jftanner - we will be migrating to that soon and do plan to make it a breaking change moving forward.

https://github.com/jaredwray/keyv/issues/1018

jaredwray commented 1 week ago

We are also considering using https://github.com/valkey-io/iovalkey to replace ioredis.

jaredwray commented 1 week ago

@100tomer

100tomer commented 1 week ago

Cool thanks for telling me about it. I already switched to another npm package but I'll be happy to switch back when it's ready.

jaredwray commented 1 week ago

Something to consider when looking at this. https://github.com/jaredwray/keyv/tree/ioredis-port-to-iovalkey

jaredwray commented 1 week ago

Cool thanks for telling me about it. I already switched to another npm package but I'll be happy to switch back when it's ready.

What library did you move too?