search

jarek-foksa / xel

Xel - Widget toolkit for building native-like Electron and Web apps
https://xel-toolkit.org
Other
696 stars 61 forks source link

Enable the demo site for Firefox #100

Closed rathboma closed 4 years ago

rathboma commented 4 years ago

Since early 2020, firefox has had support for native components, so the demo site should work now!

rathboma commented 4 years ago

I think it's just the dialog element still not supported by firefox, that should be easy to polyfill.

https://github.com/GoogleChrome/dialog-polyfill?

jarek-foksa commented 4 years ago

I tried to polyfill the <dialog> element under Safari but I gave up because I couldn't make it work inside shadow trees without ugly hacks. I also recall trying the polyfill by Google but it would fail even with the most basic examples.

rathboma commented 4 years ago

how much of Xel requires dialog? Could it just be enabled, but with a warning for elements that require it?

jarek-foksa commented 4 years ago

There are no Xel elements that would explicitly require <dialog>.

Still, I don't really have the time to deal with Firefox-specific bugs, so even with proper <dialog> implementation I would not support that browser.