search

jarek-foksa / xel

Xel - Widget toolkit for building native-like Electron and Web apps
https://xel-toolkit.org
Other
696 stars 61 forks source link

attachShadow mode closed #101

Closed ghstng closed 4 years ago

ghstng commented 4 years ago

First off, great library -- implementing (forked version currently) in https://github.com/beekeeper-studio/beekeeper-studio.

With mode 'closed' on all the elements, xel can be difficult to theme -- especially concerning dark themes (where x-menu, for example, has a hard-coded white background). Just curious if this can be opened up -- or if you have a strong reason for the current implementation.

:metal::metal:

jarek-foksa commented 4 years ago

<x-menu> does not have a hard-coded white background, themes can (and do) override it with their own stylings.

BTW, I will be adding dark themes and rewriting existing themes later this year.

ghstng commented 4 years ago

rgr