jarek-foksa / xel

Xel - Widget toolkit for building native-like Electron and Web apps
https://xel-toolkit.org
Other
689 stars 59 forks source link

"decrement-arrow" has wrong rotation #144

Open slaubenberger opened 5 months ago

slaubenberger commented 5 months ago

Hi

First of all, thank you very much for providing such a nice widget library!

Now the small issue: the "decrement-arrow" has an the wrong rotation in the following css-files: adwaita.css adwaita-dark.css cupertino.css

I fixed it by simply removing the unnecessary "rotate"-command in the css. It would be nice if you could include this fix in your main branch and upcoming releases.

Regards, Stefan

jarek-foksa commented 5 months ago

In case of adwaita.css and adwaita-dark.css the transform is redundant since the arrow icon is the "-" (minus) sign. But I'm not sure what's wrong with cupertino.css, the transform (180deg rotation) seems correct.

slaubenberger commented 5 months ago

Hmm, the strange thing is, I'm not geting +/- as signs. My signs are ^/v (up and down). On your website, I also see the +/- signs... No idea why this is happening. I just used the latest version today - the change log is 0.25.11 (2024-04-01).

jarek-foksa commented 5 months ago

Are you sure you are loading the themes correctly? My guess is that you have both Adwaita and Cupertino themes loaded simultaneously or you placed the widget inside a shadow root without adoptedStyleSheets.

slaubenberger commented 5 months ago

I'm pretty sure I use Xel the correct way, the only references are in my index.html with the following usages: xel.js adwaita.css

I'm using it in an Electron app with the following packages on a M2 Mac: ├── @electron-forge/cli@7.4.0 ├── @electron-forge/maker-deb@7.4.0 ├── @electron-forge/maker-rpm@7.4.0 ├── @electron-forge/maker-squirrel@7.4.0 ├── @electron-forge/maker-zip@7.4.0 ├── @electron-forge/plugin-auto-unpack-natives@7.4.0 ├── @electron-forge/plugin-fuses@7.4.0 ├── @electron/fuses@1.8.0 ├── electron-reload@2.0.0-alpha.1 ├── electron-reloader@1.2.3 ├── electron-squirrel-startup@1.0.0 ├── electron@30.0.1 └── xel@0.25.11

jarek-foksa commented 5 months ago

I still can't reproduce this issue. Could you please attach your index.html file? Also, what is your web browser name and version?

slaubenberger commented 5 months ago

Here you go:

index.html.zip

The result looks like this (after the rotation fix):

Screenshot 2024-04-29 at 18 14 28

The following libraries are used:

jarek-foksa commented 5 months ago

The HTML file looks fine, I guess it is a problem with the tooling that you use to generate the Electron app bundle.