search

jarek-foksa / xel

Xel - Widget toolkit for building native-like Electron and Web apps
https://xel-toolkit.org
Other
679 stars 58 forks source link

Please compile the JavaScript on your website #46

Closed tgdn closed 6 years ago

tgdn commented 6 years ago

Using classes and async on browsers that don't support it natively is not a good idea. However, your website's JS throws errors because it doesn't recognise what async means.

So impossible to see your website on Chrome because of:

xel.min.js:764 Uncaught SyntaxError: Unexpected identifier.

You should probably use something like Babel to compile your code.

another issue that you closed but which is not fixed

jarek-foksa commented 6 years ago

The current stable version of Chrome supports classes and async/await. You are right that the demo site should not be blank on older versions of Chrome. To fix it please make a pull request which adds additional checks for async/await and classes support here.

Personally, I don't care whether the site works on old Chrome versions as those have security vulnerabilities and should not be used in the first place.

Since the project targets only modern browsers and runtimes, compiling the code to older ES versions doesn't make much sense to me.