search

jarektkaczyk / eloquence-base

base for the Eloquence extensions + Searchable
https://softonsofa.com
MIT License
77 stars 69 forks source link

Replace use of deprecated starts_with/ends_with string helpers with Str::startsWith/Str::endsWith #20

Closed notf0und closed 4 years ago

notf0und commented 4 years ago

According to Laravel 6, starts_with/ends_with helper functions have been deprecated in preference of Str::startsWith/Str::endsWith

sergejostir commented 4 years ago

Why did you change the package name in composer.json?

notf0und commented 4 years ago

Why did you change the package name in composer.json?

As I use this package on my project and nobody here was answering nothing I just published my own version because I need it. Anyway I plan to rool back to this repo if the fix is accepted, cause I dont plan to mantain my repo, was just a temporary solution for me.

sergejostir commented 4 years ago

Well, then this PR is completely unsuitable for merge. It wouldn't even get published on Packagist.

notf0und commented 4 years ago

Well, then this PR is completely unsuitable for merge. It wouldn't even get published on Packagist.

https://packagist.org/packages/notf0und/eloquence-base

sergejostir commented 4 years ago

That is your package, not the one that this repo belongs to.