search

jarektkaczyk / laravel-kahlan

Laravel context for kahlan specs/tests - allows nice BDD way of developing Laravel app. https://softonsofa.com
16 stars 10 forks source link

Kahlan 4.0 #21

Open jamesst20 opened 5 years ago

jamesst20 commented 5 years ago

Hi,

Is there any chance to run this on Laravel 5.8 and Kahlan 4.0 ?

Thank you

jamesst20 commented 5 years ago

@jarektkaczyk

I gave a try to fix this library with Laravel 5.8 & Kahlan 4.5.

Here are the results (branch 5.8) https://github.com/jamesst20/laravel-kahlan https://github.com/jamesst20/kahlan-driven-laravel

All tests are passing, altough integrations one appears as "Pending" because there is no expect(...)->to...

I would love if you could have a look. You are probably way more knowledgeable than I on the correct behavior of this library.

In exchange I will make a PR and donate to your Patreon :)

jamesst20 commented 5 years ago

Due to inactivity of this project and my current need of Kahlan in my projects, I spent sometime writting a new library that answered my needs : https://github.com/jamesst20/kahlan-laravel

I will leave for a while the fork I made for this project even if it looks abandonned in case you want to take a look at it, however while the fork is currently working, there are still some fixes missing.