search

jareware / css-architecture

8 simple rules for a robust, scalable CSS architecture
2.59k stars 129 forks source link

Adding Translations section #13

Closed oieduardorabelo closed 7 years ago

oieduardorabelo commented 7 years ago

I've translated this document into PT-BR, with credits/link to the original one

Thank you so much for the awesome manifest! 🎉

jareware commented 7 years ago

Hey, that's really cool, thanks a ton!!

My only request would be to put the attribution in your article in the beginning instead of the end. The reason being that the introduction is written in the 1st person, and currently it reads as though it's the things you've learned during your years of web dev.

Would you find this a reasonable change?

oieduardorabelo commented 7 years ago

Hey @jareware,

For sure dude! :) No problem at all!

I do a lot of translations in my Medium, and the authors are ok with that. I'm sorry for not sending this PR early (and collect feedback/hear from you about the translation).

Authors normally have a Medium profile, so then, when I tag them, they send me a message etc.

Again, sorry!

I just have to thank you for your thoughts and words, is one of the best CSS manifest I've read.

I'm looking forward for the v2! 😄

I already did the change, you can check! :tada:

Many thanks!

jareware commented 7 years ago

Thanks so much for the kind words, and of course for your hard work! :bow: