search

jargij / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed
0 stars 0 forks source link

feedvalidator rejects blank stop.stop_url #101

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. validate a feed with a comma+space in stop.stop_url field

stop_id,stop_code,stop_name,stop_desc,stop_lat,stop_lon,zone_id,stop_url,lo
cation_type,parent_station
2, ,Foothill at Ferrini (W), ,35.294209,-120.673721, , , , 

All other fields with comma+blank pass validation except stop_url.

Original issue reported on code.google.com by rheitz...@gmail.com on 22 Oct 2008 at 5:32

GoogleCodeExporter commented 9 years ago 
http://code.google.com/p/googletransitdatafeed/issues/detail?id=97 is the same 
issue
and a fix is out for review that will get into the next release. I'll add a 
test for
this too.

BTW, it would be better to not put spaces in your csv. check out
http://www.rfc-editor.org/rfc/rfc4180.txt

Original comment by tom.brow...@gmail.com on 22 Oct 2008 at 5:45

GoogleCodeExporter commented 9 years ago 
I don't think 97 and 101 are about the same thing.

101 indicates that the feedvalidtor 1.1.6 fails when a blank is supplied in an 
empty 
column. Blanks have been legal up to now - I have submitted plenty of feeds 
with 
blanks in them.

I don't think 97 is correct as I have many submissions with blanks.

I didn't see any reference to blanks in the MIME spec - not sure that is a good 
controlling document any way. Most implementations I have seen trim blanks 
between 
delimiters before processing the data. If a blank is desired in needs to be 
within 
double quotes.

Original comment by rheitz...@gmail.com on 22 Oct 2008 at 8:31

GoogleCodeExporter commented 9 years ago 
You're right. issue 97 is a problem with the google-internal importer, which 
hasn't
changed so your feeds will be processed as normal. 1.1.6 changed how stops.txt 
is
processed, causing your new InvalidValue warning.
http://codereview.appspot.com/7489/show will trim whitespace and should fix 
this bug.

Original comment by tom.brow...@gmail.com on 23 Oct 2008 at 12:18

GoogleCodeExporter commented 9 years ago 
Will be fixed in the next release

Original comment by tom.brow...@gmail.com on 30 Oct 2008 at 11:49

GoogleCodeExporter commented 9 years ago

Original comment by bdfer...@google.com on 26 Sep 2014 at 4:36