search

jarhart / SublimeSBT

SBT build tool integration for Sublime Text 2 and Sublime Text 3.
MIT License
98 stars 10 forks source link

Fix for issue #9 #10

Closed qiemem closed 11 years ago

qiemem commented 11 years ago

I think the problem had to do with the fact that the subprocess started was actually bash, not sbt directly. So killing it without first sending EOF to sbt merely disconnected sbt.

The fix here simple closes stdin first. This tells sbt to shutdown. Then the process is killed.

Fix for issue #9

Note that I did not test on Windows.

jarhart commented 11 years ago

Hi,

Thanks for reporting the issue and for finding a fix already!

The issue seems to also affect "Stop SBT" for Play projects, so I think the stdin.close needs to be added to stop_sbt as well.

Thanks!

qiemem commented 11 years ago

No problem!

Note that there's still a problem if Sublime crashes, but that's not too big of a deal.