jariarkko / psgeo

Activity location library
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

We have a few places with hardcoded if(luolaseura)... -> generalize these #273

Closed ralfstrandell closed 1 year ago

ralfstrandell commented 1 year ago

Two changes:

1 Completed:

psgeoDomainDefault.sources[i].descriptionTextId and we can generate the About text in a data driven way and not with references to luolaseura in code.

2 In the making:

Now there's also showCustomLinks: boolean customLink1: {textID, URL, icon} customLink2: {textID, URL, icon} customLink3: {textID, URL, icon} Actually, these are text, not URL objects. Keep config simple.

Will implement this shortly to have the More Tools Menu (i) automagically populated with 0 to 3 links.

3 Cave classification is now a hyperlink. Instead, we have the classification in psgeodb.js. Let's use that to show dynamically generated info.

ralfstrandell commented 1 year ago

Custom links generalized to array.

ralfstrandell commented 1 year ago

There are a few non-configurable conditional branchings still, that are specific to the Finnish caving society: The display of other cave related sites in the More Info window, and some filter display related stuff. Eventuelly, this will be addressed. Refactoring Phase I (generalize and isolate settings) will go to testing first, though.

ralfstrandell commented 1 year ago

Instead of “luolaseura” we now have: