search

jaridmargolin / formatter.js

Format html inputs to match a specified pattern
http://firstopinion.github.io/formatter.js
2.48k stars 235 forks source link

Fix CommonJS requires #85

Closed marksteve closed 6 years ago

EvanHahn commented 9 years ago

:+1: on this

gajus commented 8 years ago

@Jaymon, @jaridmargolin can this be merged?

Can you add me as a contributor to GitHub/ NPM to merge PRs such as this one?

heygambo commented 7 years ago

@marksteve pls send a pull request to https://github.com/nerdyglasses/cakepan

Jaymon commented 7 years ago

@nerdyglasses @gajus I just talked with @jaridmargolin, who has committed to adding some other maintainers to the repo by end of day today (December 6, 2016)

heygambo commented 7 years ago

Really? that would be awesome. I've just started copying over the changes. I've just pushed the commonjs changes to my repo.

heygambo commented 7 years ago

https://github.com/nerdyglasses/cakepan/pull/2

heygambo commented 7 years ago

@gajus why the thumbs down?

gajus commented 7 years ago

@gajus why the thumbs down?

Please focus on supporting existing open-source effort (including liaising with project maintainers about making a release, becoming a contributor, etc) instead of forking a project and advertising it 7 hours later with a tagline:

formatter.js is dead. CakePan for the win 🎂

heygambo commented 7 years ago

it was dead for years until a few hours ago. i just need those pull request to go through. i will delete my repo once i can work with the existing one

heygambo commented 7 years ago

and i gave it a new name so it doesnt have to be formatter2.js on npm (sorry i'm on the phone. can't edit my comment above)

gajus commented 7 years ago
  1. Find the people with merge rights
  2. Email them asking to become a contributor on the basis that you have raised PRs #, #, # and are actively relying on the project, and have an established track record in the open-source community.

Chances are the author will give you a contributor status.

Don't have reputation?

Look at the PRs by other authors. Find an author with a reputation. Offer to liaise on his behalf.

Simple.

heygambo commented 7 years ago

I feel you.

I just ask you to understand my point of view as well. there is a pr somewhere where people kept asking and there was no single sign of life.

That being said. I'm looking forward to using this project instead of mine obviously and love & respect goes to all of you.

Jaymon commented 7 years ago

@gajus @nerdyglasses I apologize for this situation, it's our fault. We moved away from this internally and we should've given more people commit access.

I can be reached at jay@firstopinionapp.com if anyone needs to talk with me directly

heygambo commented 7 years ago

I have removed all my requests to send PRs to my repo and have changed the agrassive formatter.js is dead description. But I keep the repo for now so I can use it for a project until this one works.

gajus commented 7 years ago

Hi @Jaymon, thank you for the brilliant project and for taking time to follow up.

jaridmargolin commented 7 years ago

@nerdyglasses @gajus - Would like to make you both maintainers if you are interested. I think there would immense benefit in having some checks and balances before a PR is merged.

Thank you for your willingness to contribute to the project. As @Jaymon stated, it is our fault for not passing the torch earlier.

gajus commented 7 years ago

@nerdyglasses @gajus - Would like to make you both contributors if you are interested. I think there would immense benefit in having some checks and balances before a PR is merged.

I am sorry, I am out of capacity at the moment to take on the torch. However, if you make me a contributor and someone pings me for a specific PR, I will be happy to review it.

jaridmargolin commented 7 years ago

@gajus building the bot to ping you on every PR right now :)

@EvanHahn, I'm not sure if braintree is making use of formatter, but I have seen several requests come in from braintree devs. Would anyone on your team like to come on as a maintainer?

Really would love to get multiple 👀 on PRs.

gajus commented 7 years ago

@gajus building the bot to ping you on every PR right now :)

Funny enough, I am working on a project that does something very similar. :-)

EvanHahn commented 7 years ago

@jaridmargolin Braintree built Restricted Input which is a similar library. I don't think we'll be able to maintain this library, but thanks for the offer!

heygambo commented 7 years ago

@jaridmargolin sorry for the late response. I had a flu and didn't look here much.

I'm not sure I can promise anything at this time because my time is very limited. I would let you know if anything changes with my situation.

chrisdothtml commented 6 years ago

Is there any reason this hasn't been merged? This is a pretty simple/straightforward PR; not sure what more review needs to happen to it