Add support for node 8 ws urls

jaridmargolin / inspect-process

🔍 Dead simple debugging for node.js using chrome-devtools.

425 stars 26 forks source link

Add support for node 8 ws urls #53

Closed paulirish closed 7 years ago

paulirish commented 7 years ago

fixes #52

coveralls commented 7 years ago

Coverage decreased (-2.4%) to 93.103% when pulling b53b40c68ba730fff852959237190896a567251e on paulirish:node8 into aad69e58a05ce98ec673dcdc96fabce2170d83bc on jaridmargolin:dev.

paulirish commented 7 years ago

Tests now pass. I feel good about this one.

coveralls commented 7 years ago

Coverage decreased (-2.3%) to 93.162% when pulling 1cd3f45d83f34ff19ed17cf69643cfe6bcb61d7c on paulirish:node8 into aad69e58a05ce98ec673dcdc96fabce2170d83bc on jaridmargolin:dev.

coveralls commented 7 years ago

Coverage decreased (-2.3%) to 93.162% when pulling af278390b6eabab983dda783694de9cfaf48d3ae on paulirish:node8 into aad69e58a05ce98ec673dcdc96fabce2170d83bc on jaridmargolin:dev.

jaridmargolin commented 7 years ago

First of all... Thank you @paulirish. The work is greatly greatly appreciated.

Conceptually it looks great, but it unfortunately keeps getting jammed up on Travis (there are known issues with Travis + Selenium). I want to just press the "Merge Pull Request" button and look into the Travis issues at another time. You have a high degree of confidence this is working?

Did I mention thank you yet?

paulirish commented 7 years ago

Yup I feel good about it. :)