search

jaridmargolin / neutrino-contrib

A collection of neutrino plugins and presets (NOT OFFICIALLY SUPPORTED BY NEUTRINO)
5 stars 1 forks source link

Merge non-destructive style rule changes from barraponto/neutrino-preset-extractstyles #2

Closed timkelty closed 6 years ago

timkelty commented 6 years ago

This steals ideas from https://github.com/barraponto/neutrino-preset-extractstyles

Allows existing style rules to be used, instead of just deleting them.

/cc @barraponto

I also renamed the options to be options.plugin options.loaders, as this would be a breaking change anyway. That change is somewhat arbitrary.

timkelty commented 6 years ago

@jaridmargolin what do you think?

jaridmargolin commented 6 years ago

I think I feel bad I haven't merged this yet.

jaridmargolin commented 6 years ago

I will today. Sorry for the delay.

timkelty commented 6 years ago

Hah, no sweat. I was just starting a new project and remembered about it.

timkelty commented 6 years ago

Once merged, I think we should have @barraponto put up a deprecated notice on neutrino-preset-extractstyles pointing here.

barraponto commented 6 years ago

I actually updated neutrino-preset-extractstyles, in case someone was depending on that. Can we diff? I guess it's the same thing. I'd rather just add @jaridmargolin as author/owner of the package in npmjs.org (idk if that's possible).

timkelty commented 6 years ago

@barraponto either way, I think we should just make sure we end up with 1 "canonical" version.

timkelty commented 6 years ago

Ok @jaridmargolin, requested changes are pushed