search

jaridmargolin / neutrino-contrib

A collection of neutrino plugins and presets (NOT OFFICIALLY SUPPORTED BY NEUTRINO)
5 stars 1 forks source link

HMR support #3

Open timkelty opened 6 years ago

timkelty commented 6 years ago

Adding css-hot-loader support

This also clarifies some options:

Note: I branched this off of #2 to avoid conflicts, as it seemed it would be merged soon.

jaridmargolin commented 6 years ago

For the most part, this looks good.

Do we need to rename options.loader to options.extract in this PR? Seems like we would be able to add support for hot loading without making breaking changes.

If you have a minute, could you rebase these changes off of master (which now includes changes from #2)?

jaridmargolin commented 6 years ago

Also... @timkelty appreciate your work here 🙌

timkelty commented 6 years ago

@jaridmargolin don't need to for this PR, no. Just included it since we have multiple "loaders" now.

However, the currently released version also has different option names (loaderOptions, pluginOptions)

jaridmargolin commented 6 years ago

Ahh I see now. Makes complete sense. Leave it in and I will publish major version.

timkelty commented 6 years ago

Rebasing in a sec

timkelty commented 6 years ago

@jaridmargolin ok, should be ready