search

jarischaefer / docker-librenms

Docker image for LibreNMS
MIT License
117 stars 38 forks source link

PHP7.2 mcrypt extension and support. #56

Closed furhouse closed 6 years ago

furhouse commented 6 years ago

PHP 7.2 isn't supported yet, and running validate.php will throw up an error since the mcrypt extension is missing:

[FAIL]  Missing PHP extension: mcrypt
        [FIX] Please install mcrypt

(Also misses XML, but at least that package is available as php7.2-xml).

jarischaefer commented 6 years ago

The minimum PHP version has since been raised to 5.6.4 and I did not notice any errors on my instance running PHP 7.2.

I added php7.2-xml and php7.2-zip: https://github.com/jarischaefer/docker-librenms/commit/3f5d9223a95b5bc7c5a1917e6edd4140d97e6d0c

furhouse commented 6 years ago

Okay, I should've digged some more, it seems mcrypt has also been marked optional upstream, 17 days ago (after the release of 1.34). Good catch re: the zip extension. :+1:

jarischaefer commented 6 years ago

I guess the validate.php message regarding mcrypt can be ignored until they fix it.