jarle / remix-adonisjs

Build fullstack Remix applications powered by AdonisJS
https://remix-adonisjs.matstack.dev/
MIT License
35 stars 2 forks source link

Enable virtual build for test mode #51

Closed rustworthy closed 2 months ago

rustworthy commented 2 months ago

This is to be able to run end-to-end browser tests against a dev server build.

Looks like adonijs framework forces NODE_ENV to be test when running tests, I suppose this is important for some internal details or the framework or the test runner, so doing something like NODE_ENV=test npm run test or "patching" the test launch binary are not valid options.

jarle commented 2 months ago

Thanks! This seems to fix the build issues that have been happening.