search

jarmo / RAutomation

RAutomation
MIT License
100 stars 33 forks source link

Staying in Sync #25

Closed enkessler closed 12 years ago

enkessler commented 13 years ago

I see we have a new and interested developer. If the wiki is going to have an enthusiastic editor then it might be a good idea to have some of these changes put in. Also, I am thinking of doing more refactoring on RAutomation because a lot of the classes show their age. Maybe I can get some more consistency throughout it. Regardless, I'd like your feedback before I keep running down the programming road that I currently am.

jarmo commented 13 years ago

I've replied to Stephan about his proposal of creating new adapter instead. If we decide that i will do the initial extraction of UIA code out from WinFfi then i will merge this pull request - otherwise there's no point and one of you guys can use the latest state of codebase to extract it out yourselves. So it's decision time.

snscaimito commented 13 years ago

There is a good chance that I can do most of it next week. I will know more on Monday.

enkessler commented 13 years ago

And I would like to have a hand in it just for the experience at sticking in a new adapter from scratch so I'll work with Stephan if possible.

jarmo commented 13 years ago

Okay. Just start by creating new directory right beside autoit and win_ffi and then create a config for that new adapter in spec_helper. And don't forget to run win_ffi specs too once in a while to see if everything is working as expected.

On Thu, Aug 25, 2011 at 6:47 AM, enkessler < reply@reply.github.com>wrote:

And I would like to have a hand in it just for the experience at sticking in a new adapter from scratch so I'll work with Stephan if possible.

Reply to this email directly or view it on GitHub: https://github.com/jarmo/RAutomation/pull/25#issuecomment-1896891

enkessler commented 13 years ago

Speaking of running the specs for multiple adapters to make sure that nothing breaks, I don't think that anyone had ever run the public api specs with the :autoit adapter set as the default because they break. I opened an issue for it.

jarmo commented 13 years ago

They were passing some time ago...

On Thu, Aug 25, 2011 at 5:13 PM, enkessler < reply@reply.github.com>wrote:

Speaking of running the specs for multiple adapters to make sure that nothing breaks, I don't think that anyone had ever run the public api specs with the :autoit adapter set as the default because they break. I opened an issue for it.

Reply to this email directly or view it on GitHub: https://github.com/jarmo/RAutomation/pull/25#issuecomment-1900178

enkessler commented 13 years ago

I'm not sure how. The way that an :id locator is interpreted by AutoIt is quite different from how it is interpreted by UIA so :id => "the_element_id" won't work the same/at all for both adapters.

jarmo commented 13 years ago

Well, that's because there wasn't any public API tests for :id... i guess i thought at that time that :id should not be part of public API and this did the trick. I guess we'd have to do still the same.

Jarmo

On Thu, Aug 25, 2011 at 5:31 PM, enkessler < reply@reply.github.com>wrote:

I'm not sure how. The way that an :id locator is interpreted by AutoIt is quite different from how it is interpreted by UIA so :id => "the_element_id" won't work the same/at all for both adapters.

Reply to this email directly or view it on GitHub: https://github.com/jarmo/RAutomation/pull/25#issuecomment-1900327

jarmo commented 13 years ago

Wanted to point out that there is a step-by-step guide "How to create a new adapter?" in the readme (https://github.com/jarmo/RAutomation/blob/master/README.rdoc). Maybe that helps with creating that new adapter :)

jarmo commented 13 years ago

Added rake task "spec:all" for running all specs against all adapters sequentially.

jarmo commented 12 years ago

Closing this as these changes would break too much and will merge changes in when there is an additional adapter created.