jarmo
commented
11 years ago I have few comments/questions for this:
1) Why is it called items and not rows? I'd prefer API similar to Watir if it's possible:
# Table would have rows
table.rows[0].value # => "John Doe"
# add an alias for #value as #text too
table.rows[0].text # => same as #value
# possible to specify locators like with every other control
table.rows(:value => /Doe/).size # => 2; "John Doe" and "Anna Doe" both match.
# access also single control
table.row(:value => /Doe/).text # => "John Doe"
# can be also done without locators like other controls, first one will be returned
table.row.text #=> "John Doe"
# can access cells
table.rows[0].cells.size #=> 3
# of course you can also provide locators and have #text as an alias
table.rows[0].cells(:value => "FL")[0].text # => "FL"
# you can also access single cell
table.rows[0].cell(:value => "FL").text # => "FL"
# also any reason why row/rows and cell/cells couldn't be made accessible directly on the window too? This means that there should be a Window#tables, which i'm not sure exists right now...
window.rows(:text => "something") # will find all rows on all tables, which match the locator
window.cells(:text => "something") # will find all cells on all tables, which match the locatorElementCollections (https://github.com/jarmo/RAutomation/blob/master/lib/rautomation/element_collections.rb) might help you with creating support for plural methods rows/cells. There is an example at https://github.com/jarmo/RAutomation/blob/master/lib/rautomation/window.rb#L15 which is quite outdated :(
I think you get the point. Or is there any reason, why the API should be different?
2) #strings also use some kind of a rows. It should be possible to reuse your work if you've completed step 1, if i'm not mistaken. That would be awesome!
One way would be to split these things up and not make it as one large Pull request. I'd prefer that. So for example, one pull request would add Table#row(s), another one Table#cell(s) and yet another one Window#tables and then Window#row(s) and Window#cell(s). It would make reviewing your commits easier.
Anyway, i'm really thankful for your hard work so far and i'm hoping that my comments won't be a setback for you.
leviwilson
Introduced the ability to work with individual cell items in a table. Can get items (and their subitems / cells). This is dependent on pull request #37.