search

jarmo / RAutomation

RAutomation
MIT License
100 stars 33 forks source link

remove IAccessibleDLL, UiaDll and WindowsForms binaries from repo #44

Closed leviwilson closed 11 years ago

leviwilson commented 11 years ago

After doing my first rake after your build changes, I removed the binaries that were already pre-built by the rake command.

jarmo commented 11 years ago

I would not remove these yet, since release task won't build anything and gemspec only includes files with the gem, which are in git. Both of these things should be revisited and improved. And even if they're done then i find it better to have them in GitHub for now so anyone who clones this repo does not have to start messing around with building stuff they might not even need if they only want to change Ruby code for example.

leviwilson commented 11 years ago

You would have to have this setup in order to run any of the rake tasks anyway though, correct?

leviwilson commented 11 years ago

And would this fix the release task? Well, not fix, but include the last built binaries.

ext_binaries = ["ext/UiaDll/Release/UiaDll.dll", "ext/WindowsForms/Release/WindowsForms.exe"]
s.files = `git ls-files`.split("\n").concat(ext_binaries)
jarmo commented 11 years ago

I'm not sure i understood your first question.

Answer to your second question would be probably yes.

leviwilson commented 11 years ago

I understand now...I thought that rake install would also build the binaries as well. Ignore my first question.

jarmo commented 11 years ago

Yup, it does not do that currently. It should though, but it needs some investigation and coding probably.

leviwilson commented 11 years ago

Closing this pull request until we're ready to move in this direction.

jarmo commented 11 years ago

I cannot seem to reopen it. Can you?

jarmo commented 11 years ago

Does not matter. Made the changes already and pushed to git.

leviwilson commented 11 years ago

Yeah, I deleted that branch which was why you couldn't open it probably. On Dec 30, 2012 5:51 PM, "Jarmo Pertman" notifications@github.com wrote:

Does not matter. Made the changes already and pushed to git.

— Reply to this email directly or view it on GitHubhttps://github.com/jarmo/RAutomation/pull/44#issuecomment-11769764.