search

jarmo / RAutomation

RAutomation
MIT License
100 stars 33 forks source link

Keycode fix #92

Closed chrahunt closed 10 years ago

chrahunt commented 10 years ago

The code as written operated under the assumption that the keycodes for characters correspond to their ASCII values, but that is not the case outside of 0-9, a-z. This maps values to the correct key codes for symbols outside of those previously mentioned in the case where shift is not needed, and in the case where shift is needed. This makes the assumption that the user's keyboard layout is US Standard. This was already the case, it just wasn't stated explicitly.

leviwilson commented 10 years ago

Thanks! I'll take a look at this later this afternoon.

leviwilson commented 10 years ago

Looks good to me. @jarmo - want to take a look at it? We may also want this fix in the :ms_uia adapter as well.

jarmo commented 10 years ago

Cool, thanks! Merged and released 0.15.0.

@leviwilson - yeah something similar should be added to ms_uia as well although isn't there any better way to send keystrokes using UIA Automation?

leviwilson commented 10 years ago

Yes. uia gem uses http://msdn.microsoft.com/en-us/library/system.windows.forms.sendkeys.sendwait(v=vs.110).aspx On Jun 1, 2014 7:52 AM, "Jarmo Pertman" notifications@github.com wrote:

Cool, thanks! Merged and released 0.15.0.

@leviwilson https://github.com/leviwilson - yeah something similar should be added to ms_uia as well although isn't there any better way to send keystrokes using UIA Automation?

— Reply to this email directly or view it on GitHub https://github.com/jarmo/RAutomation/pull/92#issuecomment-44775841.