jarmoruuth / AutoIntegrate

PixInsight script to process FITS and other astro image files
15 stars 4 forks source link

Binning Narrowband Images #33

Closed danieldh206 closed 10 months ago

danieldh206 commented 10 months ago

https://github.com/jarmoruuth/AutoIntegrate/blob/77f26ea4d6ea655a58423dff3190236574b86444/AutoIntegrateEngine.js#L9678C1-L9678C27

When I try to bin SHO narrowband images I keep getting

ReferenceError: postfix is not defined

I believe this is because of the _function RGBNB_ChannelMapping does not find RGB channels.

I am working with QHY600 files that are huge and want to bin them.

Thank you, Daniel

jarmoruuth commented 10 months ago

Hi Daniel,

I was able to reproduce the issue. Function runBinningOnLights references to non-existing variable postfix. If replaced with a call getBinningPostfix() it works fine.

This must be an unfortunate side effect of changes done for Flowchart. Unfortunately I am in a middle of complicated change to intermediate output image names. They make no sense but are also mixed all over the place so it is messy.

So I am not sure how quickly I can post a fix. I hope to be done in a few days.

I have done also binning for QHY600 files since they can be really big.

Regards, Jarmo

danieldh206 commented 10 months ago

Which line in the script can I manually modify the getBinningPostfix() call until you get a fix? Thank you, Daniel

jarmoruuth commented 10 months ago

My line numbers are changed but you can search function runBinningOnLights in the file AutoIntegrateEngine.js. Line 2000+ something. In the second line in the the function there is call to util.addProcessingStep where you see variable postfix. Just replace postfix with getBinningPostfix().

Jarmo

jarmoruuth commented 10 months ago

Fix for this is now available in my PixInsight test repository: https://ruuth.xyz/test/autointegrate/

danieldh206 commented 10 months ago

Just to verify, is v1.6.5.2 test2 the correct version? I had a little difficult trying to get the update from the test repository.

jarmoruuth commented 10 months ago

Yes, that is the correct version.

Jarmo

danieldh206 commented 10 months ago

I just ran a Ha_LRGB data set through the test version and binning worked correctly! Thank you.

jarmoruuth commented 10 months ago

Great that you verified it! So this is fixed in v1.65.2.