search

jarnedemeulemeester / findroid

Third-party native Jellyfin Android app
GNU General Public License v3.0
2.67k stars 167 forks source link

App crashes when using experimental mpv player #805

Closed Grummm closed 3 months ago

Grummm commented 3 months ago

Describe the bug Since version 0.15.0 when playing any media with the experimental mpv player the app crashes.

To Reproduce Steps to reproduce the behavior:

  1. In video player setting enable mpv player.
  2. Try to play any media on your jellyfin server.

Expected behavior It should just play the media with mpv.

Device info (please complete the following information):

jmqm commented 3 months ago

Unsure if the same issue, but mine crashes consistently when playing downloaded media. Previously it crashed often, now it crashes all the time. Before when I turn on offline mode it rarely crashed, now it doesn't matter.

MPV settings: mediacodec gpu audiotrack

Findroid 0.15.0 (26)

Jcuhfehl commented 3 months ago

c6c5011 might be at fault. I tested it and removing the fix seemed fine, but maybe it depends on the device or something? @Grummm is this only on downloaded media or also on streamed? Since the original issue was only for downloaded playback.

Natanel-Shitrit commented 3 months ago

Happens for me too, only downloaded media.

Grummm commented 3 months ago

Doesn't matter for me, happens with both downloaded and streamed media. Haven't had the chance to test it on other devices though.

And what do you mean with the original issue? Haven't been using findroid for that long but never had any issues playing downloaded media with mpv.

Jcuhfehl commented 3 months ago

And what do you mean with the original issue? Haven't been using findroid for that long but never had any issues playing downloaded media with mpv.

I don't think this was ever an issue on a release, but during initial development of download playback there was a similar crash which was (in some weird way) fixed by adding a 1ms delay. That delay was removed in this release because in both my and Jarne's testing it wasn't needed anymore, but it might still be needed after all.

formeo14 commented 3 months ago

Thanks. I thought that it was a general issue with the new version. I did not think of the mpv player.

jarnedemeulemeester commented 3 months ago

Should be fixed with ~c3539fa9bb24e1faecb2a96e97a5989438eaa3fa~ more fixes in 2af5c792efe2cf49c7d80df2cee94c15b5fa293e I will do some more testing before releasing a new version since there is still one other crash related to mpv

kpdh commented 3 months ago

I have the same issue specifically with downloaded media. Any update on when we can expect a push to the play store?

jarnedemeulemeester commented 3 months ago

Creating a new release now. If the problem persists, reopen this one or create a new issue.

Grummm commented 3 months ago

Damn you're fast!