Cannot log in when device name is blank

[niravjdn]

Describe the bug I am getting an error while trying to login to jellyfin server 10.9.0 from Findroid on Android 13 Lenovo tablet. It works on my Android 11 Samsung Note 10 but only getting error on Tablet.

To Reproduce Steps to reproduce the behavior:

1. Enter Server url as 192.168.2.xxx:8096
2. Enter username and password
3. Error will be shown

Screenshots https://imgur.com/df0STEg

Device info (please complete the following information):

• Device: [e.g. Lenovo Tab P11 2nd Gen]
• Android version: [e.g. 13]
• App version: [e.g. v0.15.2 )]
• Jellyfin version: [e.g. 10.9.0]

Logs on Jellyfin Server:

AuthenticateByName.
System.ArgumentException: The value cannot be an empty string. (Parameter 'request.DeviceName')
   at System.ArgumentException.ThrowNullOrEmptyException(String argument, String paramName)
   at System.ArgumentException.ThrowIfNullOrEmpty(String argument, String paramName)
   at Emby.Server.Implementations.Session.SessionManager.AuthenticateNewSessionInternal(AuthenticationRequest request, Boolean enforcePassword)
   at Jellyfin.Api.Controllers.UserController.AuthenticateUserByName(AuthenticateUserByName request)
   at lambda_method1733(Closure, Object)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.AwaitableObjectResultExecutor.Execute(ActionContext actionContext, IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask`1 actionResultValueTask)
   at

[jarnedemeulemeester]

It seems like your device name is an empty string. Please check the name of your device in the settings app and set it to a non empty string.

[niravjdn]

Device name is already set but it does not work. Seems an issue how findroid is reading device name, It might not pick on lenovo tabs.

[niravjdn]

@jarnedemeulemeester Please help

[jarnedemeulemeester]

This is an issue that Lenovo needs to solve. We are using the correct the correct Android API to retrieve the device name. What happens if you change the device name? Do you still get the error?

[niravjdn]

Yes, Even after changing device name I get an error.

[niravjdn]

Can you please tell me where do we try to get device name in code? For my use case, I can compile app locally by hardcoding it or trying to get Bluetooth adapter name.

[niravjdn]

If I use device info app from playstore, It is able to fetch device name.

[jarnedemeulemeester]

The device name is read in the Jellyfin Kotlin SDK https://github.com/jellyfin/jellyfin-sdk-kotlin/blob/master/jellyfin-core/src/androidMain/kotlin/org/jellyfin/sdk/android/AndroidDevice.kt#L12

I will try pushing a workaround to the SDK upstream.

[niravjdn]

Thanks. Waiting for fix to be shipped to app 😊

[jarnedemeulemeester]

The fix has been merged upstream! It is expected to ship around the time that Jellyfin 10.10.1 releases

[jarnedemeulemeester]

This should now be fixed when a new release of Findroid is published