search

jarnedemeulemeester / findroid

Third-party native Jellyfin Android app
GNU General Public License v3.0
2.67k stars 167 forks source link

Auto skip intro/credits toggle #851

Open GillyTheGhillie opened 1 month ago

GillyTheGhillie commented 1 month ago

Describe the solution you'd like It would be nice to have an option in the settings to automatically skip intros and credits instead of having to manually press the skip intro/credits button. As I understand it the intro/credit skip in Findroid simply uses the timestamp data from jumoog's plugin rather than using the plugin to handle the actual skipping.

Describe alternatives you've considered I believe the default auto skip in the plugin settings for jumoog's intro skipper currently only works with the web player and players based off of that (e.g. official android app web player)

foux commented 1 month ago

Don't forget that segments will be a core feature of jellyfin in 10.10. So perhaps we should stop looking specifically in Intro Skipper functionnality (and API), which seems a loss of time with 10.10 so close.

UriSheinman commented 1 month ago

I think this has a setting in the plugin...

foux commented 1 month ago

WIth Jellyfin 10.10 only a week away, it is important to stop thinking about the plugin, and start thinking with the internal Jellyfin implementation of the segments.

UriSheinman commented 1 month ago

WIth Jellyfin 10.10 only a week away, it is important to stop thinking about the plugin, and start thinking with the internal Jellyfin implementation of the segments.

I think it'll take sometime until everyone transition, it's good to have a backup for legacy users instead of just throwing away the work done...

GillyTheGhillie commented 1 month ago

I think this has a setting in the plugin...

My understanding (and this may be wrong) is that Findroid only uses the timestamp data from the plugin, it doesn't use any of its functionality. I've tried toggling auto skip on and off and it hasn't made any difference to the behaviour in Findroid.

GillyTheGhillie commented 1 month ago

WIth Jellyfin 10.10 only a week away, it is important to stop thinking about the plugin, and start thinking with the internal Jellyfin implementation of the segments.

I still think auto skip could be something worth implementing for the official segment implementation.

foux commented 1 month ago

WIth Jellyfin 10.10 only a week away, it is important to stop thinking about the plugin, and start thinking with the internal Jellyfin implementation of the segments.

I still think auto skip could be something worth implementing for the official segment implementation.

I agree with that. I'm just saying there's no need to spend time on the plugin, when dozens or other plugins will be created with the implementation of segments.