search

jarodburchill / project-automation

Python script for creating new projects (React, Express.js, Vue, Laravel, etc.) in the desired local directory, with a GitHub origin.
MIT License
43 stars 7 forks source link

Refactor for more editor support #8

Closed ajnieset closed 5 years ago

ajnieset commented 5 years ago

Changed the logic to allow for many editors

Rexogamer commented 5 years ago

Hmmm... looks good, but I feel problems may arise.

Rexogamer commented 5 years ago

note to reviewer: I made some edits and have forked Austin’s fork so he’ll have to merge those first

ajnieset commented 5 years ago

What problems do feel may arise?

Rexogamer commented 5 years ago

If the editor’s command is different from most I guess... although in that case I presume we’d add an exception.

Also, I opened a PR on your fork

ajnieset commented 5 years ago

yea thats kind of why i added the try except block so that it errors out on wrong/not found commands for editors. But the setup config should be setup properly by the user, so there is some reliance that the user knows a little bit on what they are doing. Ive skimmed your PR and it i do like the documentation to help with editor support.

jarodburchill commented 5 years ago

Austin, if you like the changes Ed made, merge them into this pull request so I can see everything in one place! Thanks guys!