search

jarohen / chord

A library designed to bridge the gap between the triad of CLJ/CLJS, web-sockets and core.async.
439 stars 40 forks source link

Removed dependency on org.clojure/tools.reader because it triggers a JS error #14

Closed giuliano108 closed 10 years ago

giuliano108 commented 10 years ago

Hi James,

running the example project results, on my system, in a JS error: Uncaught TypeError: undefined is not a function. I think the root cause is similar to http://dev.clojure.org/jira/browse/CLJS-685 (cljs.core.PersistentArrayMap is undefined). Removing the explicit dependency on tools.reader seems to fix it.

cheers, __ Giuliano

jarohen commented 10 years ago

Hi Giuliano - thanks for the PR! I often struggle with the version incompatibilities of CLJS/tools.reader - seems like sometimes you have to specify them manually, sometimes you have to omit them etc...

@matlux - does this solve the issue we spoke about over email?

James

matlux commented 10 years ago

Hi James,

Thanks to you and Giuliano, Chord example now works on my side. It's gonna be a useful base to use to fix the same issue I have on my project.

It can be time consuming and difficult to find version compatibilities between all components as you say. Not to mention the browser which caches when you don't expect, giving false positives or false negatives.

I'll test the same on my project and see if I gives some resolution.

Thanks, Mathieu

On 21 April 2014 10:53, James Henderson notifications@github.com wrote:

Hi Giuliano - thanks for the PR! I often struggle with the version incompatibilities of CLJS/tools.reader - seems like sometimes you have to specify them manually, sometimes you have to omit them etc...

@matlux https://github.com/matlux - does this solve the issue we spoke about over email?

James

— Reply to this email directly or view it on GitHubhttps://github.com/james-henderson/chord/pull/14#issuecomment-40926371 .

Regards, Mathieu Gauthron

Director Matlux Ltd +447728407050

charles-dyfis-net commented 10 years ago

My own investigation here indicated that cljs 0.0-2202 works correctly with tools/reader 0.8.3, and fails in the manner described here with 0.8.4.

Should Chord be compatible with 0.8.3, downgrading is probably appropriate.