search

jaroschek / home-assistant-myuplink

Custom Home Assistant integration for devices and sensors in myUplink account.
39 stars 8 forks source link

Update displayed naming and avoid duplicated sensors from api #108

Closed elden1337 closed 2 days ago

elden1337 commented 2 months ago

This pr aims to further improve the readability of the many many sensors we get from myuplink, at least with certain hvac-types. See if you approve, i have removed the device_id from the name as it was obscuring the readability. I also added the id in parenthesis in the end.

Furthermore, in api.py i've introduced a check for duplicated points since i've seen that these do occur. Imo this should not be possible but to prevent issues or missmatching sensors in HA I suggest we patch it like this til it's fixed on the myuplink-side.

When reviewing this, please do consider any implications the renaming may have for future sensor_ids. The current ids should stay the same as they did with my instance. Also check so that you agree with my distinct-selection in api.py

Thanks.

elden1337 commented 2 months ago

Example from my instance running the new code. As you can see here it wouldnt be possible to distinguish these sensors without the id.

image