jaroslawhartman / TimeZones-Alfred

Alfred Workflow
https://jhartman.pl/tag/time-zones/
Apache License 2.0
497 stars 21 forks source link

Cannot add a new city #1

Closed jaroslawhartman closed 5 years ago

jaroslawhartman commented 5 years ago

Due to new policy at google maps, conversion Location -> Time zone does not work.

Keyless access to Google Maps Platform is deprecated. Please use an API key with all your API calls to avoid service interruption. For further details please refer to http://g.co/dev/maps-no-account

jaroslawhartman commented 5 years ago

Fixed in version 2.0

hanoii commented 5 years ago

I am not sure on this one, I might give a try to make something functional with something other than google, but I wonder if it wouldn't have made more sense to provide a way to configure an API.

Glad I found the older version as I might fork it from there. Thanks!

jaroslawhartman commented 5 years ago

Hi,

I'm not sure if I'm following... Since version 2.0 Google API is not needed anymore. I also made a lot of simplification to remove dependencies to online APIs.

Do you still have problems with this release?

Thank you!

hanoii commented 5 years ago

@jaroslawhartman HI! The problem with the current approach (the CSV) is that allows no update. We are now in a timespan where several timezones are changing (London, New York) do to day time savings, how were you planning to account for those?

I still think that some API is needed, either google or something else, and the only thing about google is that you know need an API key that for some is not easy to get. I just wanted to bring back some way to have an updated timezone.

jaroslawhartman commented 5 years ago

HI! The problem with the current approach (the CSV) is that allows no update. We are now in a timespan where several timezones are changing (London, New York) do to day time savings, how were you planning to account for those?

Is explicit update really needed? Intention behind current version is that DST changes are accommodated automatically. At least DST change I have had last weekend went fine.

Thank you, Jarek

jaroslawhartman commented 5 years ago

Reopening until clarifying.

jaroslawhartman commented 5 years ago

Hi @hanoii, any more thoughts? Especially regarding my previous comment?

Thank you

hanoii commented 5 years ago

@jaroslawhartman sorry, was intending to review it properly. I can tell you that London timezone didn't change when I looked at it, but wanted to check it again properly. You are saying you are accounting for DST on your own.. what if the rules/day changes?

ugolafosse commented 5 years ago

Hi, I'm trying to add a new time zone like Paris|France|Europe/Paris|FR|33 so did I on the edit timezone txt but nothing changes, by the way the "timezone add" is not working and directly going to this :

capture d ecran 2018-11-09 a 17 57 30 capture d ecran 2018-11-09 a 17 57 45
jaroslawhartman commented 5 years ago

Hi @MrJekkyl

Thank you for this report. Which version you're on? I hoped it will work better in v2.1... If you're not on 2.1, can you try download latest version from e.g. https://jhartman.pl/download/alfred-timezone-workflow/

It's how it works on my version of 2.1. Please note that after typing timezone add you should keep typing your city, to get whole sentence timezone add paris eventually. I admit, these search options are confusing...

image

Give a try please. If no luck, select Edit file with defined cities:

image

and add

Paris|France|Europe/Paris|FR|33

Eventually my file is:

#Version2.0
London|United Kingdom|Europe/London|GB|44
New Delhi|India|Asia/Kolkata|IN|91
New York|United States|America/New_York|US|1
Paris|France|Europe/Paris|FR|33
Warsaw|Poland|Europe/Warsaw|PL|48

Which is reflected as:

image

If still no luck, let's continue our troubleshooting.

Best regards, Jarek

ugolafosse commented 5 years ago

Problem SOLVED ! Thank you for the Tuto And Great work Cheers

jaroslawhartman commented 5 years ago

@MrJekkyl , what was the issue after all?

ugolafosse commented 5 years ago

Sorry, when adding timezone the transition is not immediate so the "google/amazon/wiki search" stays temporarily. By the way it's the V2.0 that appears on the workflow preferences but it's a detail. Great tutorial that needed to be done by the way

jaroslawhartman commented 5 years ago

By the way it's the V2.0 that appears on the workflow preferences but it's a detail.

Yeah, noticed that... Raised #8 for that, will be fixed next time.

Best regards, Jarek

jaroslawhartman commented 5 years ago

Closing - since no more feedback and I believe that this has been fixed.