jarpy / lambkin

CLI tool for generating and managing simple functions in AWS Lambda
Apache License 2.0
74 stars 12 forks source link

Failure when run from path with spaces #10

Open steven-collins-omega opened 7 years ago

steven-collins-omega commented 7 years ago

The workaround for this is obvious enough, but I thought you might want to know about the error:

(es-curator) AUS-SCollins:serverless-curator scollins$ lambkin build
/bin/sh: /Users/scollins/Google Drive/GitHub/LocalPartners/ELK/logstash/serverless-curator/venv/bin/pip: "/Users/scollins/Google: bad interpreter: No such file or directory
Traceback (most recent call last):
  File "/Users/scollins/.virtualenvs/es-curator/bin/lambkin", line 11, in <module>
    sys.exit(main())
  File "/Users/scollins/.virtualenvs/es-curator/lib/python2.7/site-packages/lambkin/lambkin.py", line 240, in main
    cli()
  File "/Users/scollins/.virtualenvs/es-curator/lib/python2.7/site-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/Users/scollins/.virtualenvs/es-curator/lib/python2.7/site-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/Users/scollins/.virtualenvs/es-curator/lib/python2.7/site-packages/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/scollins/.virtualenvs/es-curator/lib/python2.7/site-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/scollins/.virtualenvs/es-curator/lib/python2.7/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/Users/scollins/.virtualenvs/es-curator/lib/python2.7/site-packages/lambkin/lambkin.py", line 85, in build
    print run_in_virtualenv('pip install -r requirements.txt')
  File "/Users/scollins/.virtualenvs/es-curator/lib/python2.7/site-packages/lambkin/virtualenv.py", line 26, in run_in_virtualenv
    return check_output('. venv/bin/activate && %s' % command, shell=True)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '. venv/bin/activate && pip install -r requirements.txt' returned non-zero exit status 126
jarpy commented 7 years ago

Thanks for the report, and sorry for the slow response.

This seems to be a limitation of Virtualenv, so I'm not sure if there's a good fix in Lambkin.

https://bugs.python.org/issue20622