search

jarrett / rbbcode

Converts BBCode to HTML. Gracefully handles invalid input. Built on Treetop.
41 stars 9 forks source link

Missing dependency #12

Closed mszyndel closed 11 years ago

mszyndel commented 11 years ago

There was runtime dependency missing: sanitize. There I fixed it.

BTW you have typo in readme link to sanitize...

jarrett commented 11 years ago

Thanks! Good catch.

mszyndel commented 11 years ago

@jarrett you still did not fix missing dependency.

jarrett commented 11 years ago

Weird. I merged your pull request, but it didn't seem to take. Can you make another pull request?

Sent from my iPhone

On Nov 6, 2012, at 7:51 AM, Mike Szyndel notifications@github.com wrote:

@jarrett you still did not fix missing dependency.

— Reply to this email directly or view it on GitHub.

mszyndel commented 11 years ago

@jarrett you didn't merge it, just closed, afaik.

On Tue, Nov 6, 2012 at 4:16 PM, jarrett notifications@github.com wrote:

Weird. I merged your pull request, but it didn't seem to take. Can you make another pull request?

Sent from my iPhone

On Nov 6, 2012, at 7:51 AM, Mike Szyndel notifications@github.com wrote:

@jarrett you still did not fix missing dependency.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/jarrett/rbbcode/pull/12#issuecomment-10114037.

jarrett commented 11 years ago

Can you please reinstate the pull request? I don't see one open.

On Tue, Nov 6, 2012 at 9:35 AM, Mike Szyndel notifications@github.comwrote:

@jarrett you didn't merge it, just closed, afaik.

On Tue, Nov 6, 2012 at 4:16 PM, jarrett notifications@github.com wrote:

Weird. I merged your pull request, but it didn't seem to take. Can you make another pull request?

Sent from my iPhone

On Nov 6, 2012, at 7:51 AM, Mike Szyndel notifications@github.com wrote:

@jarrett you still did not fix missing dependency.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub< https://github.com/jarrett/rbbcode/pull/12#issuecomment-10114037>.

— Reply to this email directly or view it on GitHubhttps://github.com/jarrett/rbbcode/pull/12#issuecomment-10114783.

jarrett commented 11 years ago

Nevermind. I was able to reopen it myself. Thanks! I'll release a new version.

jarrett commented 11 years ago

Ok, the new version is released. It's rbbcode 1.0.2.

mszyndel commented 11 years ago

Thank you! :)