search

jarro2783 / cxxopts

Lightweight C++ command line option parser
MIT License
4.22k stars 592 forks source link

Inconsistent indentation in namespaces #340

Closed eyalroz closed 2 years ago

eyalroz commented 2 years ago

Many definitions/declarations in namespace cxxopts are indented by 2 spaces. But - the implementation functions (inline's after the class definitions) - are not indented. Suggest not indenting within namespaces, consistently.

jarro2783 commented 2 years ago

I was probably going for declarations being indented and the actual code not indented, but as you noticed this just leads to inconsistencies.

eyalroz commented 2 years ago

As I'm working on #240 , I'm finding the namespace indentation super-annoying. Would really like it to go away. Would you take a PR for that?