search

jarro2783 / cxxopts

Lightweight C++ command line option parser
MIT License
4.16k stars 582 forks source link

Output same exception messages for both Linux and Windows #395

Closed nigels-com closed 1 year ago

nigels-com commented 1 year ago

While it is indeed pleasing to see UTF-8 output on Linux, we strongly prefer cross-platform consistency to help with testing.

If this approach is too heavy-handed, I could refactor with some sort of opt-out for this.

This change is Reviewable

jarro2783 commented 1 year ago

This was done originally because Windows couldn't display these characters correctly. Can you check that the output looks sensible on Windows?

nigels-com commented 1 year ago

Yes, so the change to go for lowest common denominator - ASCII.

jarro2783 commented 1 year ago

I guess this is fine. Maybe I'll build in an opt out later.

nigels-com commented 1 year ago

Thanks for that. Appreciated!