search

jarro2783 / cxxopts

Lightweight C++ command line option parser
MIT License
4.16k stars 582 forks source link

Don't split by list delimiter in positional lists #398

Closed agalanin closed 1 year ago

agalanin commented 1 year ago

cxxopts splits positional arguments in last catch-all positional argument by comma. This alters the content of positional arguments that's not what I expect

This change is Reviewable

avighnac commented 1 year ago

Is this being maintained?

jarro2783 commented 1 year ago

Yes. I don't have a lot of time to work on this, but I will try to get to this PR soon.

jarro2783 commented 1 year ago

This looks ok, but I want to see the CI build run. I'm not sure why it hasn't triggered. Can you rebase and push again?

agalanin commented 1 year ago

rebased

jarro2783 commented 1 year ago

Thanks for the contribution. This definitely makes sense, if someone wants to split positional arguments they can just use a space.